Make more class attributes inheritable #1255
Conversation
| class_attribute :_type, instance_reader: true | ||
| class_attribute :_attributes | ||
| self._attributes ||= [] | ||
| class_attribute :_attributes_keys |
There was a problem hiding this comment.
style-wise, should the assignments be right next to eachother, rather than separated by a class_attribute definition?
There was a problem hiding this comment.
well, I guess it's my personal preference to group that kind of stuff together. makes it slightly easier to skim, imo
There was a problem hiding this comment.
Ex or pr?
B mobile phone
On Oct 7, 2015, at 6:36 AM, L. Preston Sego III notifications@github.com wrote:
In lib/active_model/serializer.rb:
with_options instance_writer: false, instance_reader: false do |serializer|
class_attribute :_type, instance_reader: trueclass_attribute :_attributesself._attributes ||= []class_attribute :_attributes_keys—
Reply to this email directly or view it on GitHub.
There was a problem hiding this comment.
Meant example code of what you prefer.
B mobile phone
On Oct 8, 2015, at 2:53 PM, L. Preston Sego III notifications@github.com wrote:
In lib/active_model/serializer.rb:
with_options instance_writer: false, instance_reader: false do |serializer|
class_attribute :_type, instance_reader: trueclass_attribute :_attributesself._attributes ||= []class_attribute :_attributes_keys—
Reply to this email directly or view it on GitHub.
There was a problem hiding this comment.
@bf4 I think he prefers having all the class_attribute grouped together, and then the stuff ||= stuff. I personally do not have an opinion on the matter.
There was a problem hiding this comment.
I don't think i like either but inclined to this. Good to merge?
B mobile phone
On Oct 8, 2015, at 6:25 PM, Lucas Hosseini notifications@github.com wrote:
In lib/active_model/serializer.rb:
with_options instance_writer: false, instance_reader: false do |serializer|
class_attribute :_type, instance_reader: trueclass_attribute :_attributesself._attributes ||= []class_attribute :_attributes_keys—
Reply to this email directly or view it on GitHub.
|
@rails-api/ams nu? |
|
LGTM 👍 |
|
LTGM 👍 On Thu, Oct 8, 2015, 6:37 PM Lucas Hosseini notifications@github.com
|
Make more class attributes inheritable
No description provided.