Move from ActiveModelSerializers::Model to ActiveModel::Serializer::Model

[maurogeorge]

Hi guys,

Today the ActiveModelSerializers::Model is the only public API under this namespace.

To keep consistency move to ActiveModel::Serializer::Model.

Makes sense to you?

Thanks

[bf4]

I put it there on purpose, see (ongoing) discussion of the reasons in #1298

Holding this for now

[NullVoxPopuli]

@maurogeorge I think the consensus was to use ActiveModel::Serializers::_____, so-- can you update this PR, accordingly?

[bf4]

Consensus?

B mobile phone

On Nov 4, 2015, at 12:30 PM, L. Preston Sego III notifications@github.com wrote:

@maurogeorge I think the consensus was to use ActiveModel::Serializers::_____, so-- can you update this PR, accordingly?

—
Reply to this email directly or view it on GitHub.

[bf4]

Should we rename the gem, too, then?

B mobile phone

On Nov 4, 2015, at 12:30 PM, L. Preston Sego III notifications@github.com wrote:

@maurogeorge I think the consensus was to use ActiveModel::Serializers::_____, so-- can you update this PR, accordingly?

—
Reply to this email directly or view it on GitHub.

[NullVoxPopuli]

@bf4

• RFC: Primary namespace: ActiveModel::Serializer, ActiveModel::Serializers, vs. ActiveModelSerializers #1310 (comment)
• RFC: Primary namespace: ActiveModel::Serializer, ActiveModel::Serializers, vs. ActiveModelSerializers #1310 (comment) (kinda)
• RFC: Primary namespace: ActiveModel::Serializer, ActiveModel::Serializers, vs. ActiveModelSerializers #1310 (comment)

The gem is already active_model_serializers, which I think fits well with ActiveModel::Serializers::___

[maurogeorge]

@NullVoxPopuli thanks for the feedback. I will wait for a feedback of the team #1310 (comment) and when we have in the same page I will work on it.

[bf4]

But the gem is not activemodel::serializers and rails has that namespace already

B mobile phone

On Nov 4, 2015, at 1:31 PM, L. Preston Sego III notifications@github.com wrote:

@bf4

#1310 (comment)
#1310 (comment) (kinda)
#1310 (comment)
The gem is already active_model_serializers, which I think fits well with ActiveModel::Serializers::___

—
Reply to this email directly or view it on GitHub.

[bf4]

This can't be merged until #1310 is resolved

Changing the gem name is a pretty big deal, as is piggy-backing on existing rails namespaces

[NullVoxPopuli]

the rails namespace is a module, which is fine.
as long as we keep the ...::Serializers a module, they can co-exist

[bf4]

Closing as resolved in #1310

[maurogeorge]

👍