0.8 ActiveModel::Serializer _fast_attributes - raise NameError without backtrace #1305
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For this test I'm getting ~x2 improvement on JRuby.
NameError is used internally for flow controll. Backtrace is not needed, so I'm not raising it.
Links: https://github.com/jruby/jruby/wiki/BacktraceGeneration https://www.coffeepowered.net/2011/06/17/jruby-performance-exceptions-are-not-flow-control/
u is istance of User class from bench/perf.rb
without patch:
with: