Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions lib/action_controller/serialization.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
require 'active_support/core_ext/class/attribute'
require 'action_controller/serialization/context'

module ActionController
module Serialization
Expand Down Expand Up @@ -47,7 +46,7 @@ def use_adapter?

[:_render_option_json, :_render_with_renderer_json].each do |renderer_method|
define_method renderer_method do |resource, options|
options.fetch(:serialization_context) { options[:serialization_context] = Context.new(request) }
options.fetch(:context) { options[:context] = request }
serializable_resource = get_serializer(resource, options)
super(serializable_resource, options)
end
Expand Down
13 changes: 0 additions & 13 deletions lib/action_controller/serialization/context.rb

This file was deleted.

2 changes: 1 addition & 1 deletion lib/active_model/serializer/adapter/json_api.rb
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ def add_included_resources_for(serializer, include_tree, primary_data, included)
end

def links_for(serializer, options)
JsonApi::PaginationLinks.new(serializer.object, options[:serialization_context]).serializable_hash(options)
JsonApi::PaginationLinks.new(serializer.object, options[:context]).serializable_hash(options)
end
end
end
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,11 @@ def pages_from
end

def url(options)
@url ||= options.fetch(:links, {}).fetch(:self, nil) || request_url
@url ||= options.fetch(:links, {}).fetch(:self, nil) || original_url
end

def request_url
@request_url ||= context.request_url
def original_url
@original_url ||= context.original_url[/\A[^?]+/]
end

def query_parameters
Expand Down
12 changes: 0 additions & 12 deletions lib/active_model/serializer/railtie.rb
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,6 @@ class Railtie < Rails::Railtie
end
end

initializer 'active_model_serializers.url_helpers' do
ActiveSupport.on_load(:action_controller) do
ActiveModelSerializers.url_helpers = Module.new do
include Rails.application.routes.url_helpers

def self.default_url_options
ActionController::Base.default_url_options
end
end
end
end

initializer 'generators' do |app|
app.load_generators
require 'generators/serializer/resource_override'
Expand Down
2 changes: 0 additions & 2 deletions lib/active_model_serializers.rb
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ module ActiveModelSerializers
mattr_accessor :logger
self.logger = Rails.logger || Logger.new(IO::NULL)

mattr_accessor :url_helpers

extend ActiveSupport::Autoload
autoload :Model

Expand Down
4 changes: 2 additions & 2 deletions test/adapter/json_api/pagination_links_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@ def setup

def mock_request(query_parameters = {}, original_url = URI)
context = Minitest::Mock.new
context.expect(:request_url, original_url)
context.expect(:original_url, original_url)
context.expect(:query_parameters, query_parameters)
@options = {}
@options[:serialization_context] = context
@options[:context] = context
end

def load_adapter(paginated_collection, options = {})
Expand Down