rename context to serialization_context

[tchak]

A resubmit of my earlier PR. Removed all references to url_helpers for now. See #1289 (comment) for reference

cc @bf4

[NullVoxPopuli]

LGTM 👍

[beauby]

I'm not sure the Context class belongs in ActionController, as we might want to use it for non-AC related stuff as well. Some mixin/concern definitely belongs here, but I think the base Context class should be part of the ActiveModel(::)Serializer(s) namespace. Thoughts?

[NullVoxPopuli]

I agree - action controller isn't ever going to really make use of the context, where as it is AMS that utilizes context.

[NullVoxPopuli]

The action controller only creates the context, and that's it

[bf4]

It's not in action_controller, it's namespaced within actioncontroller::serialization which is fine by me

[bf4]

Alternative: lib/active_model_serializers/serialization_context.rb

module ActiveModelSerializers
  class SerializationContext
    #etc
  end
end

[bf4]

speaking for myself, I would mere that in the next 10 minutes

[beauby]

Yeah, let's put it in active_model_serializers/serialization_context and I'm OK to merge.

[NullVoxPopuli]

👍

[bf4]

@tchak amend commit, force push, and we'll merge

[bf4]

@tchak want one of us to do it?

[tchak]

@bf4 fixed and rebased. Sorry for the delay!

[NullVoxPopuli]

Looks good to me. We are still in disarray about namespacing, but that's outside the scope of this.

good work!