Fix bundler caching in travis & Appveyor #1341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Caching is now working. Future builds should happen much faster!
|
johnhamelink
changed the title
- Point gems to vendor/bundle in travis.yml - Point Travis cache to vendor/bundle - Point Appveyor cache to vendor/bundle
johnhamelink
force-pushed
the
fix-travis
branch
from
6c0cf66 to
defd8d0
Compare
| @@ -12,8 +9,10 @@ rvm: | |||
| - ruby-head | |||
| - rbx-2 | |||
|
|
|||
| install: | |||
| - bundle install --retry=3 | |||
| install: bundle install --path=vendor/bundle --retry=3 --jobs=3 | |||
There was a problem hiding this comment.
weird. I thought travis just did this
There was a problem hiding this comment.
The reason it wasn't caching was because the bundle install command was explicitly defined, so it overrode whatever default travis defines. I fixed this by setting a dir to install into, then explicitly telling travis to cache that dir 😄
bf4
added a commit
that referenced
this pull request
Nov 24, 2015
Fix bundler caching in travis & Appveyor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed while working on #1336 that Grape is not caching Gems correctly:
This PR is an attempt to fix this.