[WIP] Add support for polymorphic associations. #1453
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 20, 2016
|
I know this seems a |
| @@ -78,6 +78,17 @@ def build_association(subject, parent_serializer_options) | |||
|
|
|||
| private | |||
|
|
|||
| def polymorphic_key(assoc_value) | |||
| reflection_key = assoc_value.class.model_name | |||
| assoc_value.respond_to?(:each) ? reflection_key.plural : reflection_key.singular | |||
There was a problem hiding this comment.
😘 what I need, I'm merging this in a branch of mine 😁
There was a problem hiding this comment.
Cool, tell me whether this worked! (usage is has_one :addressable, polymorphic: true)
joaomdmoura
changed the title
|
|
||
| def reflection_options(assoc_value, options) | ||
| reflection_options = options.dup | ||
| reflection_options[:key] = polymorphic_key(assoc_value) if options[:polymorphic] && !options.key?(:key) |
There was a problem hiding this comment.
Note: We might want to make it a ||= in order not to override user-provided options (instead of testing for !options.key?(:key)).
|
After giving it a thought, I'm not sure this feature really makes sense (especially in the case of to-many relationships and empty to-ones). |
|
Closing, this does not make any sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly choose the association key for polymorphic associations.