Make serializers serializable, step 1. #1494
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is a first step in a good idea...
This comes up not infrequently, especially as it was an interface in previous releases.
Now, a serializer responds to
serializable_hash
,as_json
,to_json
,to_h
, andto_hash
as is expected from experience, and sorta makes sense, as well. (to_h and to_hash are sentinels Ruby uses for generating json etc)e.g. #1487
Obviously it needs tests, but I wanted to just get the idea out there.
re step 2, it's non-trivial.. I futzed a bit in bf4/active_model_serializers@serializable_serializer...serializable_serializers and bf4/active_model_serializers@serializable_serializer...serializable_serializers_take1
ref: