-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add resource-level meta docs. Update top-level meta docs. #1566
Conversation
@@ -81,8 +81,12 @@ PR please :) | |||
|
|||
#### meta | |||
|
|||
If you want a `meta` attribute in your response, specify it in the `render` | |||
call: | |||
A `meta` member can be used to include non-standard meta-information. `meta` can |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/non-standard/custom
(or something to that effect)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, although that's copy from the JSON API docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. I saw that later :embarrassed:
On Wed, Mar 9, 2016 at 8:40 AM Ben Mills notifications@github.com wrote:
In docs/general/rendering.md
#1566 (comment)
:@@ -81,8 +81,12 @@ PR please :)
meta
-If you want a
meta
attribute in your response, specify it in therender
-call:
+Ameta
member can be used to include non-standard meta-information.meta
canSure, although that's copy from the JSON API docs.
—
Reply to this email directly or view it on GitHub
https://github.com/rails-api/active_model_serializers/pull/1566/files#r55526872
.
LGTM, i'll merge, unless @bf4 has actionable comments |
Haven't had time to review. I trust it's an improvement, which is the most important thing. First, do no harm and all. B mobile phone
|
looks good then, further changes, could be in an additional PR. :-) |
Add resource-level meta docs. Update top-level meta docs.
Purpose
Improve meta documentation.
Changes
Related GitHub issues
#1235