Lazify calculating caller file digest until used #1687
Conversation
|
|
||
| def _cache_digest | ||
| return @_cache_digest if defined?(@_cache_digest) | ||
| @_cache_digest = digest_caller_file(_cache_digest_file_path) |
There was a problem hiding this comment.
Could be rewritten as @_cache_digest ||= digest_caller_file(_cache_digest_file_path) instead of the two lines.
There was a problem hiding this comment.
You're right. It should never be nilnor empty
On Mon, Apr 18, 2016 at 6:04 PM Lucas Hosseini notifications@github.com
wrote:
In lib/active_model/serializer/caching.rb
#1687 (comment)
:@@ -42,7 +43,12 @@ module ClassMethods
def inherited(base)
super
caller_line = caller[1]
base._cache_digest = digest_caller_file(caller_line)base._cache_digest_file_path = caller_lineend
def _cache_digestreturn @_cache_digest if defined?(@_cache_digest)@_cache_digest = digest_caller_file(_cache_digest_file_path)Could be rewritten as @_cache_digest ||=
digest_caller_file(_cache_digest_file_path) instead of the two lines.—
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub
https://github.com/rails-api/active_model_serializers/pull/1687/files/1d24c9708ae802ec449664f82746d93d8fa345c0#r60149660
No description provided.