Meta no longer handled in Base adapter. #1695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| hash = serializable_hash(options) | ||
| include_meta(hash) | ||
| hash | ||
| serializable_hash(options) | ||
| end |
There was a problem hiding this comment.
alias method should be fine here, unless we want to keep the root option here like in the am:s:j in rails
There was a problem hiding this comment.
It failed because the alias would be bound to the pre-inheritance placeholder method.
|
Tests failing because of cyclomatic complexity of |
|
@beauby wow, yeah -- it doesn't even look that bad. As a whole, LGTM, nice work |
|
Now Appveyor is failing for no reason. |
|
👍 |
bf4
added a commit
to bf4/active_model_serializers
that referenced
this pull request
May 2, 2016
bf4
added a commit
to bf4/active_model_serializers
that referenced
this pull request
May 17, 2016
bf4
added a commit
to bf4/active_model_serializers
that referenced
this pull request
May 17, 2016
NullVoxPopuli
pushed a commit
that referenced
this pull request
May 17, 2016
* Assert Schema * Fix regression from #1695 where JSONAPI renders empty meta * Add changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make each relevant adapter (i.e.
JsonandJsonApi) handle top levelmeta.