Skip to content

Fix appveyor setting for JRuby #1706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2016
Merged

Fix appveyor setting for JRuby #1706

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,21 +3,19 @@ version: '{build}'
skip_tags: true

environment:
JRUBY_OPTS: "--dev -J-Xmx1024M --debug"
matrix:
- ruby_version: "21"
- ruby_version: "21-x64"
- ruby_version: "jruby-9.0.4.0"
- ruby_version: "Ruby21"
- ruby_version: "Ruby21-x64"
- ruby_version: "jruby-9.0.0.0"
Copy link
Member

@bf4 bf4 Apr 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we lowering the Jruby version? and putting the JRUBY_OPTS globally?

Copy link
Contributor Author

@mtsmfm mtsmfm Apr 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only available jruby-9.0.0.0 on appveyor:
https://ci.appveyor.com/project/mtsmfm/active-model-serializers/build/1

putting the JRUBY_OPTS globally?

Yeah, I went same way for travis but it is not smart 😕

https://github.com/rails-api/active_model_serializers/blob/master/.travis.yml#L25-L26

Should I apply patch for that on this PR or create another PR?


cache:
- vendor/bundle

install:
- SET PATH=C:\Ruby%ruby_version%\bin;%PATH%
- ruby --version
- gem --version
- SET PATH=C:\%ruby_version%\bin;%PATH%
- gem install bundler
- bundler --version
- bundle platform
- bundle env
Copy link
Member

@bf4 bf4 Apr 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing bundle env is sufficient for ruby --version, gem --version bundler --version and bundle platforM?

Copy link
Contributor Author

@mtsmfm mtsmfm Apr 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it will output more useful and correct information about its environments:

Environment

    Bundler   1.11.2
    Rubygems  2.4.8
    Ruby      2.2.2p0 (2015-07-21 revision 50293) [java]
    Git       2.7.1.windows.2
...

https://ci.appveyor.com/project/bf4/active-model-serializers/build/10/job/0846cedglubbskwo#L10

ruby --version is not correct for JRuby because binary name is jruby so jruby --version is correct:

https://ci.appveyor.com/project/mtsmfm/active-model-serializers/build/3/job/k31toapvkg9osoli#L7

We don't have to take care about that to use bundle env.

- bundle install --path=vendor/bundle --retry=3 --jobs=3

test_script:
Expand Down