Improve readability of relationships test #1904
Conversation
bf4
force-pushed
the
fix_intermittent_relationship_test_failures
branch
2 times, most recently
from
3e6a79d to
0bd17a6
Compare
bf4
changed the title
bf4
force-pushed
the
fix_intermittent_relationship_test_failures
branch
3 times, most recently
from
1f9dfaa to
dd8e147
Compare
| end | ||
|
|
||
| def test_take2_relationship_simple_link | ||
| expected = { |
There was a problem hiding this comment.
example of tests that test at very different levels
- test_relationship_simple_link
- test_take2_relationship_simple_link
There was a problem hiding this comment.
what's the purpose of all the take2 tests? other than seemingly having more setup and logic to assert
There was a problem hiding this comment.
Merging two test files; need to disambiguate
|
was there anything left to do on this other than the rebase? |
I accidentally introduced the duplication when merging rails-api#1543 (comment) and they've evolved separately since then. They both have some value and need to be combined.
bf4
force-pushed
the
fix_intermittent_relationship_test_failures
branch
from
dd8e147 to
baa4716
Compare
bf4
force-pushed
the
fix_intermittent_relationship_test_failures
branch
2 times, most recently
from
6ebdaee to
35f38dc
Compare
bf4
force-pushed
the
fix_intermittent_relationship_test_failures
branch
4 times, most recently
from
5371c40 to
e7e0126
Compare
bf4
force-pushed
the
fix_intermittent_relationship_test_failures
branch
from
e7e0126 to
4b72742
Compare
|
|
||
| def test_relationship_with_nil_serializer |
There was a problem hiding this comment.
a relationship with a nil serializer that isn't using virtual values (i.e. doesn't need a serializer in the firsts place) isn't a supported use case
There was a problem hiding this comment.
In practice, AMS will try to call as_json on the data object
| model_attributes = { blog: Blog.new(id: 1) } | ||
| relationship_name = :blog | ||
| model = new_model(model_attributes) | ||
| actual = build_serializer_and_serialize_relationship(model, relationship_name) do |
There was a problem hiding this comment.
I really like this pattern, of defining the serializer for test in the test itself
NullVoxPopuli
deleted the
fix_intermittent_relationship_test_failures
branch
#1902 was not enough, it appears