Fix mt6 assert_nil warnings #2017

bf4 · 2017-01-06T20:23:26Z

Fix MT6 assert_nil warnings
- introduced, discussion assert_equal should not allow nil for "expected" minitest/minitest#626
  - objections and discussion minitest/minitest@922bc91#commitcomment-20072731
  - good example of how this is a good thing assert_equal should not allow nil for "expected" minitest/minitest#626 (comment)
- better warning Fix warning for must_equal nil minitest/minitest#660
Tidy up the tests #1423

bundle exec rake test test:isolated 1>/dev/null
$HOME/.rvm/rubies/ruby-2.2.5/bin/ruby -w -I"lib:lib:test" -r./test/test_helper.rb  -w -I".bundle/ruby/2.2.0/gems/rake-11.3.0/lib" ".bundle/ruby/2.2.0/gems/rake-11.3.0/lib/rake/rake_test_loader.rb" "test/**/*_test.rb"
Use assert_nil if expecting nil from test/action_controller/serialization_scope_name_test.rb:78:in `test_default_serialization_scope_object'. This will fail in MT6.
Use assert_nil if expecting nil from test/cache_test.rb:174:in `test_cache_options_definition'. This will fail in MT6.
Use assert_nil if expecting nil from test/cache_test.rb:185:in `test_associations_separately_cache'. This will fail in MT6.
Use assert_nil if expecting nil from test/cache_test.rb:186:in `test_associations_separately_cache'. This will fail in MT6.
Use assert_nil if expecting nil from test/cache_test.rb:131:in `test_cache_key_definition'. This will fail in MT6.
Use assert_nil if expecting nil from test/adapter/json_api/include_data_if_sideloaded_test.rb:162:in `assert_relationship'. This will fail in MT6.
Expected string default value for '--test-framework'; got false (boolean)
Expected string default value for '--test-framework'; got false (boolean)
Use assert_nil if expecting nil from test/serializers/serializer_for_test.rb:74:in `test_serializer_for_existing_serializer_with_lookup_disabled'. This will fail in MT6.
Use assert_nil if expecting nil from test/serializers/serializer_for_test.rb:62:in `test_serializer_for_non_ams_serializer'. This will fail in MT6.
Use assert_nil if expecting nil from test/serializers/serializer_for_test.rb:131:in `test_serializer_for_nested_resource_with_lookup_disabled'. This will fail in MT6.
Use assert_nil if expecting nil from test/serializers/serializer_for_test.rb:117:in `test_serializer_for_namespaced_resource_with_lookup_disabled'. This will fail in MT6.
Use assert_nil if expecting nil from test/serializers/serializer_for_test.rb:79:in `test_serializer_for_not_existing_serializer'. This will fail in MT6.
Use assert_nil if expecting nil from test/serializers/serializer_for_test.rb:91:in `test_serializer_inherited_serializer_with_lookup_disabled'. This will fail in MT6.
Use assert_nil if expecting nil from test/active_model_serializers/railtie_test_isolated.rb:35:in `block in <class:WithRails>'. This will fail in MT6.
Use assert_nil if expecting nil from test/serializers/caching_configuration_test_isolated.rb:139:in `block in <class:PerformCachingFalse>'. This will fail in MT6.
Use assert_nil if expecting nil from test/serializers/caching_configuration_test_isolated.rb:140:in `block in <class:PerformCachingFalse>'. This will fail in MT6.
Use assert_nil if expecting nil from test/serializers/caching_configuration_test_isolated.rb:141:in `block in <class:PerformCachingFalse>'. This will fail in MT6.
Use assert_nil if expecting nil from test/serializers/caching_configuration_test_isolated.rb:72:in `block in <class:PerformCachingTrue>'. This will fail in MT6.
Use assert_nil if expecting nil from test/serializers/caching_configuration_test_isolated.rb:73:in `block in <class:PerformCachingTrue>'. This will fail in MT6.
Use assert_nil if expecting nil from test/serializers/caching_configuration_test_isolated.rb:74:in `block in <class:PerformCachingTrue>'. This will fail in MT6.

mention-bot · 2017-01-06T20:23:28Z

@bf4, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bolshakov, @dubadub and @dgynn to be potential reviewers.

bf4 · 2017-01-06T22:35:47Z

test/grape_test.rb

-require 'grape'
+TestHelper.silence_warnings do
+  require 'grape'
+end


@rails-api/ams @rails-api/commit This commit is kind of unnecessary... might be easier to implement in grape.. :)

bf4 · 2017-01-07T04:39:04Z

test/adapter/json_api/include_data_if_sideloaded_test.rb

-            assert_equal(expected, hash[:data][:relationships][relationship_name])
+            actual = hash[:data][:relationships][relationship_name]
+            if expected.nil?
+              assert_nil(actual)


I should check if this is a bug when expected is nil

bf4 · 2017-01-07T04:51:18Z

test/adapter/json_api/include_data_if_sideloaded_test.rb

-            expected = nil
-            assert_relationship(:unlinked_tags, expected)
+            expected = { meta: {} }
+            assert_relationship(:unlinked_tags, expected, key_transform: :unaltered)


this was returning nil before since the key was unaltered-tags. I'm not sure if meta: {} is the desired behavior, but it's what the current behavior is.

NullVoxPopuli · 2017-01-07T21:04:34Z

test/action_controller/serialization_scope_name_test.rb

    end

+    def current_user
+      defined?(@current_user) ? @current_user : :current_user_not_set


that's a fun way to do it.

NullVoxPopuli · 2017-01-07T21:06:00Z

LGTM 👍

Fix mt6 assert_nil warnings

* Merge pull request #1990 from mxie/mx-result-typo Fix typos and capitalization in Relationship Links docs [ci skip] * Merge pull request #1992 from ojiry/bump_ruby_versions Run tests by Ruby 2.2.6 and 2.3.3 * Merge pull request #1994 from bf4/promote_architecture Promote important architecture description that answers a lot of questions we get Conflicts: docs/ARCHITECTURE.md * Merge pull request #1999 from bf4/typos Fix typos [ci skip] * Merge pull request #2000 from berfarah/patch-1 Link to 0.10.3 tag instead of `master` branch * Merge pull request #2007 from bf4/check_ci Test was failing due to change in JSON exception message when parsing empty string * Swap out KeyTransform for CaseTransform (#1993) * delete KeyTransform, use CaseTransform * added changelog Conflicts: CHANGELOG.md * Merge pull request #2005 from kofronpi/support-ruby-2.4 Update jsonapi runtime dependency to 0.1.1.beta6 * Bump to v0.10.4 * Merge pull request #2018 from rails-api/bump_version Bump to v0.10.4 [ci skip] Conflicts: CHANGELOG.md * Merge pull request #2019 from bf4/fix_method_redefined_warning Fix AMS warnings * Merge pull request #2020 from bf4/silence_grape_warnings Silence Grape warnings * Merge pull request #2017 from bf4/remove_warnings Fix mt6 assert_nil warnings * Updated isolated tests to assert correct behavior. (#2010) * Updated isolated tests to assert correct behavior. * Added check to get unsafe params if rails version is great than 5 * Merge pull request #2012 from bf4/cleanup_isolated_jsonapi_renderer_tests_a_bit Cleanup assertions in isolated jsonapi renderer tests a bit * Add Model#attributes helper; make test attributes explicit * Fix model attributes accessors * Fix typos * Randomize testing of compatibility layer against regressions * Test bugfix * Add CHANGELOG * Merge pull request #1981 from groyoh/link_doc Fix relationship links doc Conflicts: CHANGELOG.md

* Merge pull request rails-api#1990 from mxie/mx-result-typo Fix typos and capitalization in Relationship Links docs [ci skip] * Merge pull request rails-api#1992 from ojiry/bump_ruby_versions Run tests by Ruby 2.2.6 and 2.3.3 * Merge pull request rails-api#1994 from bf4/promote_architecture Promote important architecture description that answers a lot of questions we get Conflicts: docs/ARCHITECTURE.md * Merge pull request rails-api#1999 from bf4/typos Fix typos [ci skip] * Merge pull request rails-api#2000 from berfarah/patch-1 Link to 0.10.3 tag instead of `master` branch * Merge pull request rails-api#2007 from bf4/check_ci Test was failing due to change in JSON exception message when parsing empty string * Swap out KeyTransform for CaseTransform (rails-api#1993) * delete KeyTransform, use CaseTransform * added changelog Conflicts: CHANGELOG.md * Merge pull request rails-api#2005 from kofronpi/support-ruby-2.4 Update jsonapi runtime dependency to 0.1.1.beta6 * Bump to v0.10.4 * Merge pull request rails-api#2018 from rails-api/bump_version Bump to v0.10.4 [ci skip] Conflicts: CHANGELOG.md * Merge pull request rails-api#2019 from bf4/fix_method_redefined_warning Fix AMS warnings * Merge pull request rails-api#2020 from bf4/silence_grape_warnings Silence Grape warnings * Merge pull request rails-api#2017 from bf4/remove_warnings Fix mt6 assert_nil warnings * Updated isolated tests to assert correct behavior. (rails-api#2010) * Updated isolated tests to assert correct behavior. * Added check to get unsafe params if rails version is great than 5 * Merge pull request rails-api#2012 from bf4/cleanup_isolated_jsonapi_renderer_tests_a_bit Cleanup assertions in isolated jsonapi renderer tests a bit * Add Model#attributes helper; make test attributes explicit * Fix model attributes accessors * Fix typos * Randomize testing of compatibility layer against regressions * Test bugfix * Add CHANGELOG * Merge pull request rails-api#1981 from groyoh/link_doc Fix relationship links doc Conflicts: CHANGELOG.md

bf4 commented Jan 6, 2017

View reviewed changes

This was referenced Jan 6, 2017

Fix AMS warnings #2019

Merged

Silence Grape warnings #2020

Merged

bf4 force-pushed the remove_warnings branch from 044bdaa to 93dbc5b Compare January 6, 2017 23:21

Fix MT6 assert_nil warnings

6acb405

bf4 force-pushed the remove_warnings branch from 93dbc5b to 6acb405 Compare January 7, 2017 04:06

bf4 changed the title ~~Fix warnings~~ Fix mt6 assert_nil warnings Jan 7, 2017

bf4 commented Jan 7, 2017

View reviewed changes

Fix test bug found by assert_nil

4dfbe27

bf4 commented Jan 7, 2017

View reviewed changes

Improve tests found by assert_nil

c52af54

bf4 force-pushed the remove_warnings branch from 5c476ae to c52af54 Compare January 7, 2017 05:17

NullVoxPopuli reviewed Jan 7, 2017

View reviewed changes

bf4 merged commit 3b155de into rails-api:master Jan 7, 2017

bf4 deleted the remove_warnings branch January 7, 2017 21:23

bf4 added a commit that referenced this pull request Jan 7, 2017

Merge pull request #2017 from bf4/remove_warnings

a5423da

Fix mt6 assert_nil warnings

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix mt6 assert_nil warnings #2017

Fix mt6 assert_nil warnings #2017

Uh oh!

bf4 commented Jan 6, 2017 •

edited

Loading

Uh oh!

mention-bot commented Jan 6, 2017

Uh oh!

bf4 Jan 6, 2017

Uh oh!

bf4 Jan 7, 2017

Uh oh!

bf4 Jan 7, 2017

Uh oh!

NullVoxPopuli Jan 7, 2017

Uh oh!

NullVoxPopuli commented Jan 7, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Fix mt6 assert_nil warnings #2017

Fix mt6 assert_nil warnings #2017

Uh oh!

Conversation

bf4 commented Jan 6, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mention-bot commented Jan 6, 2017

Uh oh!

bf4 Jan 6, 2017

Choose a reason for hiding this comment

Uh oh!

bf4 Jan 7, 2017

Choose a reason for hiding this comment

Uh oh!

bf4 Jan 7, 2017

Choose a reason for hiding this comment

Uh oh!

NullVoxPopuli Jan 7, 2017

Choose a reason for hiding this comment

Uh oh!

NullVoxPopuli commented Jan 7, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bf4 commented Jan 6, 2017 •

edited

Loading