Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version constraint for jsonapi-renderer #2057

Merged
merged 1 commit into from
Feb 20, 2017

Conversation

jaredbeck
Copy link
Contributor

Now that we are no longer using the deprecated jsonapi (#2055) we can discuss updating the version constraint of jsonapi-renderer.

Currently (2017-02-20) the latest version is 0.1.2.

Why not use a version constraint like '~> 0.1.1'? Because we know of no reason why 0.1.1.beta1 cannot still be used. That said, we have done no research looking for such a reason.

@mention-bot
Copy link

@jaredbeck, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bf4, @steveklabnik and @dubadub to be potential reviewers.

@bf4
Copy link
Member

bf4 commented Feb 20, 2017

Great. @jaredbeck could you add a changelog under feature?

Currently (2017-02-20) the latest version is 0.1.2.

Why not use a version constraint like '~> 0.1.1'? Because
we know of no reason why 0.1.1.beta1 cannot still be used.
That said, we have done no research looking for such a reason.
@jaredbeck jaredbeck force-pushed the jsonapi-renderer-0.1.2 branch from 8acf161 to 1005aa6 Compare February 20, 2017 20:03
@jaredbeck
Copy link
Contributor Author

Great. @jaredbeck could you add a changelog under feature?

Added.

Sorry Benjamin, I keep forgetting the changelog entry. I don't know why, as I keep changelogs on all my own projects!

@bf4 bf4 merged commit 6fbf59f into rails-api:master Feb 20, 2017
@jaredbeck jaredbeck deleted the jsonapi-renderer-0.1.2 branch February 20, 2017 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants