Fix checking of method defined or not #2427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathieujobin
approved these changes
Mar 3, 2022
The `Module#method_defined?` works for an instance method. But `with_unbundled_env` defines as a class method. Therefore, the current check doesn't work as expected. ```ruby require "bundler" puts Bundler.method_defined?(:with_unbundled_env) # => false puts Bundler.respond_to?(:with_unbundled_env) # => true ``` This fixes the following message that shows when running a test. ``` [DEPRECATED] `Bundler.with_clean_env` has been deprecated in favor of `Bundler.with_unbundled_env`. If you instead want the environment before bundler was originally loaded, use `Bundler.with_original_env` (called at /home/y-yagi/src/github.com/rails-api/active_model_serializers/Rakefile:68) ```
wasifhossain
force-pushed
the
fix-bundler-deprecated-method
branch
from
e082bba to
d40140b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Module#method_defined?works for an instance method. Butwith_unbundled_envdefines as a class method. Therefore, the current check doesn't work as expected.This fixes the following message that shows when running a test.