Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly formatting passed in serializer namespace #783

Closed

Conversation

antstorm
Copy link

This fix allows to pass namespace: :api, with a lowercase :api. Old format, of course, is still supported.

@antstorm
Copy link
Author

Any chance of getting this in?

@saneshark
Copy link

@antstorm I'm not sure that this really adds anything useful and it would kind of make things confusing if it were ever introduced into the Readme as such, because you could have more than one module in the namespace and there would be no way to present that if you pass in a symbol, right?

namespace: 'Api::V1'
# vs.
namespace: :api ???

@antstorm
Copy link
Author

@saneshark sure, there's no way of specifying two or more nested modules in a symbol. My reasoning behind this change is to keep things consistent with Rails, which has namespace :api in the router, that is then used to prefix your controllers with Api::.

It might be hard to compare these two cases, because router does much more than just prefixes controller classes, but still I think that's a valid point.

@kurko
Copy link
Member

kurko commented Mar 19, 2015

We need more people chiming in here to make a decision.

@groyoh
Copy link
Member

groyoh commented Mar 27, 2016

This issue does not seem to have moved for quite a while. I'm closing it. If somebody like this should be re-opened, feel free to leave a comment.

@groyoh groyoh closed this Mar 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants