Replace has_one with attribute in template

[bf4]

has_one is no longer supported

this way we generate valid templates

[kurko]

I believe it should be belongs_to, not attribute.

[bf4]

If you say so. There's basically no usage tests around this code. Would you like me to change it?

The generator defines association_names as

def association_names
  attributes.select { |attr| attr.reference? }.map { |a| a.name.to_sym }
end

belongs_to

    # Defines an association in the object that should be rendered.
    #
    # The serializer object should implement the association name
    # as a method which should return an object when invoked. If a method
    # with the association name does not exist, the association name is
    # dispatched to the serialized object.
    def self.belongs_to(*attrs)
      associate(:belongs_to, attrs)
    end

Whereas attribute

    def self.attribute(attr, options = {})
      key = options.fetch(:key, attr)
      @_attributes.concat [key]
      define_method key do
        object.read_attribute_for_serialization(attr)
      end unless method_defined?(key)
    end

I'm not really sure where reference? comes from. Seems to be a schema definition for a has_many, no?

[kurko]

Nevermind. I misread this PR before.

[bf4]

Thanks!

[bf4]

@kurko Any desire to revert this since was re-added in #725 ? I'm happy to submit a PR.

[kurko]

Yes, definitely.

[bf4]

Done