Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store options in array serializers #837

Merged
merged 2 commits into from
Mar 11, 2015
Merged

Store options in array serializers #837

merged 2 commits into from
Mar 11, 2015

Conversation

kurko
Copy link
Member

@kurko kurko commented Mar 11, 2015

  1. In my previous PR, I forgot to cover ArraySerializer. This fixes it.
  2. Options need to be passed down into the associations as well. Eg. in a PostsController you want to pass in some arguments that will make comments be presented in a different way. This accomplishes that. https://github.com/rails-api/active_model_serializers/pull/837/files#diff-a97213928a042d41b4d8d56281b7049eR68 is an example of how it'd work.

kurko added 2 commits March 11, 2015 16:14
@kurko
Stores passed in options in array serializers
bcd3844 
This is supported in single serializers. This adds support for passing
options from array serializers to each serializer in it.
@kurko
Passes serializer options down into associations
af81a40
guilleiguaran added a commit that referenced this pull request Mar 11, 2015
@guilleiguaran
Merge pull request #837 from rails-api/store-options-in-array-seriali…
4b32e39 
…zers

Store options in array serializers
@guilleiguaran guilleiguaran merged commit 4b32e39 into master Mar 11, 2015
@guilleiguaran guilleiguaran deleted the store-options-in-array-serializers branch March 11, 2015 20:50
@joaomdmoura joaomdmoura restored the store-options-in-array-serializers branch July 13, 2015 22:46
@joaomdmoura joaomdmoura deleted the store-options-in-array-serializers branch July 13, 2015 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kurko @guilleiguaran