Add url option to assocation for jsonapi #840
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 13, 2015 11:10
…te a url instead of using a link object
Contributor
Author
|
This may need to change depending on feedback for json-api/json-api#453 |
Member
|
FYI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the url option to associations to tell the jsonapi adapter to use a url instead of a link object.
The adapter assumes that the correct url can be generated using
named_routes.In order to generate the urls, the adapter is given the controller instance to use to generate the urls. Let me know if I should be exposing url generation abilities is some other way.
Fixes #834