Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates rails versions for test and dev #885

Merged
merged 1 commit into from
Apr 27, 2015
Merged

Updates rails versions for test and dev #885

merged 1 commit into from
Apr 27, 2015

Conversation

tonyta
Copy link
Contributor

@tonyta tonyta commented Apr 27, 2015

While looking to contribute, I saw that .travis.yml and Gemfile were outdated for AMS v0.10.0rc:

Changes:

  • Removes test env using Rails 3.2 (AMS10 depends on >=4.0)
  • Adds test env for Rails 4.2 and sets it as default RAILS_VERSION
  • Removes explicit requirement for arel master since v6.0.0 was released

Hope this is helpful! 😸

@tonyta
removes test env for incompatible Rails 3.2 and adds Rails 4.2
b224d50 
gemspec requires "rails" and "activemodel, ">= 4.0", so testing
on 3.2 will always fail to resolve dependencies.

adds and defaults to Rails 4.2 when RAILS_VERSION is not specified
@tonyta
Copy link
Contributor Author

tonyta commented Apr 27, 2015

Whoops! Looks like arel master is still required since Rails master is tracking an unpublished arel v7.0.0. Removing commit 6290669 ...

@tonyta tonyta force-pushed the updates-rails-versions-for-test-and-dev branch from 6290669 to b224d50 Compare April 27, 2015 01:41
@joaomdmoura joaomdmoura added this to the 0.10 milestone Apr 27, 2015
@joaomdmoura
Copy link
Member

LGTM, thank you @tonyta 😄 merging it

joaomdmoura added a commit that referenced this pull request Apr 27, 2015
@joaomdmoura
Merge pull request #885 from tonyta/updates-rails-versions-for-test-a…
b706e52 
…nd-dev

Updates rails versions for test and dev
@joaomdmoura joaomdmoura merged commit b706e52 into rails-api:master Apr 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S: Ready for PR V: 0.10.x
Projects
None yet
Milestone
0.10
Development

Successfully merging this pull request may close these issues.
2 participants
@tonyta @joaomdmoura