Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverting PR #909 #930

Merged
merged 1 commit into from
May 28, 2015
Merged

Reverting PR #909 #930

merged 1 commit into from
May 28, 2015

Conversation

joaomdmoura
Copy link
Member

Reverting PR #909 but also and adding json api usage advise on readme

@steveklabnik
Copy link
Contributor

😢 😢 😢 😢

@joaomdmoura
Copy link
Member Author

😭 sorry @seveklabnik , but I know we will define it as default soon! 😞
In the mean while we should promote it on some JS frameworks! It will help us into build a a standard and push jsonapi forward.

@steveklabnik
Copy link
Contributor

I think this works against that goal :/

@spastorino
Copy link
Contributor

As I told you guys, let's not try to accomplish everything in one move.
AMS with JSON API as default won't be accepted in Rails. AMS with json adapter by default and an easy way to switch to JSON API will be.

@spastorino
Copy link
Contributor

I'm totally fine with both ways for me it's just a switch I have to change to use what I need.
The thing is right now JSON API is not accepted as default in Rails.
If AMS' default adapter is JSON API I'm perfectly fine but I can't merge Rails API unless I completely remove AMS as a dependency on Rails side and I think that's much worse.

@joaomdmoura
Copy link
Member Author

It's indeed worse Steve. This is why I agree with Santiago on this. Being integrated into Rails might even help  us in the long run when promoting json app. 

João M. D. Moura

On Wed, May 27, 2015 at 7:18 PM, Santiago Pastorino
notifications@github.com wrote:

I'm totally fine with both ways for me it's just a switch I have to change to use what I need.
The thing is right now JSON API is not accepted as default in Rails.

If AMS' default adapter is JSON API I'm perfectly fine but I can't merge Rails API unless I completely remove AMS as a dependency on Rails side and I think that's much worse.

Reply to this email directly or view it on GitHub:
#930 (comment)

@joaomdmoura
Copy link
Member Author

As I discussed on IRC with @spastorino, it seem that you @steveklabnik, also agreed on this for now, so I'm merging it.

joaomdmoura added a commit that referenced this pull request May 28, 2015
@joaomdmoura joaomdmoura merged commit 35fb9de into rails-api:master May 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants