Add some failing tests around has_many assocs ..where no serializer is defined for the thing that is has_many'd #955
Conversation
..where no serializer is defined for the thing that is has_many'd
|
The three tests are probably redundant, but I can remove which ever ones aren't helpful. |
|
Great @JustinAiken, now we can keep working into this branch using the tests as reference 😄 |
|
In looking at this, is the problem that we have a record with a serializer, and one of its associations has a an enumerable object such as an array of hash whose elements don't implement ActiveModel::Serialization? So is the problem in not having a pass-through-serializer that arrayserializer can call or in calling the array serializer in the first place? I'm been playing with this a bit, and think it might just be better to not use AMS to serialize objects that it doesn't know how to serialize... that's the renderer's job, no? |
|
This works inasmuch as it doesn't crash, but I'm not sure if the end behavior is what we want 56a7bd1 fwiw (that commit is orphaned, not merged anywhere) |
|
The commit in this PR is now included in #962. Propose closing (and thanks!) 😄 |
|
Just waiting the merge before closing all issues related to it @bf4 |
As requested in #877