Skip to content

Conversation

@andsip
Copy link
Contributor

@andsip andsip commented Oct 15, 2024

Fix queries with date and date-time placeholder conditions such as:

where("written_on < ?", Date.today)
where("written_on < ?", DateTime.current) 

This should fix #1243.

@aidanharan
Copy link
Contributor

Could you add a few tests and update the CHANGELOG?

@andsip
Copy link
Contributor Author

andsip commented Oct 15, 2024

I don't see any tests that have been added in the last several changes in this code part.. Could you point me to the test file, where similar functionality is being tested already?

@aidanharan aidanharan changed the title Add check for Date to #basic_attribute_type? Fix queries with date and date-time placeholder conditions Oct 15, 2024
@aidanharan aidanharan merged commit c137deb into rails-sqlserver:main Oct 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue with date values in queries

2 participants