Update dependencies for Windows build and drop 32-bit support #567
+33
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new action allows us to specify if the MSSQL server should enforce encryption at all times. This helps us to verify that our precompiled build on Windows, where we compile OpenSSL ourselves, will work as expected.
Also bump the cache key to force a recompilation of freetds against the new OpenSSL version.
aharpervc
approved these changes
Nov 19, 2024
| @@ -138,12 +140,12 @@ jobs: | |||
| Copy-Item -Path ".\tmp\tiny_tds-$gemVersion-$rubyArchitecture\ports" -Destination "." -Recurse | |||
|
|
|||
| - name: Setup MSSQL | |||
| uses: potatoqualitee/mssqlsuite@v1.7 | |||
| uses: andyundso/setup-mssql@v1 | |||
There was a problem hiding this comment.
Worth bringing this into the rails-sqlserver github org?
| * Raise error if FreeTDS is unable to sent command buffer to the server | ||
| * Use freetds v1.4.23, libiconv v1.17 and OpenSSL v3.4.0 for Windows builds |
There was a problem hiding this comment.
- extconts sets these versions for all platforms, right? And it's that their statically linked for Windows. But building for other platforms would also use these versions?
- Any concern doing this large of a version jump for OpenSSL?
| with: | ||
| install: sqlengine, sqlclient | ||
| components: sqlcmd,sqlengine |
There was a problem hiding this comment.
Should this be a yaml list instead of a comma delimited string?
Comment on lines
+223
to
+224
| - "false" | ||
| - "true" |
There was a problem hiding this comment.
Why are these strings instead of actual true/false?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #526
Relates to #552
The main goal of this PR is to update dependencies for the precompiled Windows build. However, it also contains a few other changes.
I replaced the action we use to setup the MSSQL server for testing. I developed the new action myself. It contains three advantages over the previous action:
The last point is relevant since I planned to update the OpenSSL version in the Windows build. I wanted to make sure that such a major upgrade will not cause any issues for the end users. Connections to MSSQL servers are unencrypted by default, so I suspected that even if freetds will compile against OpenSSL v3, the relevant encryption code is not used at all. By adjusting our CI to force encryption to the MSSQL server, I think this scenario is covered well. This is only done on Windows, as on Linux, everybody compiles freetds on their own.
The dependency updates for the Windows build are:
In this process, I also dropped the 32-bit build for Windows. It was untested and in very low demand (see #552 for details).