Use model reference from env when it is available #161
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
get_session_model
method will store a reference to the model inrequest.env[SESSION_RECORD_KEY]
when the session is loaded. Later on when saving the session,write_session
callsget_session_model
, which again calls the active record finder methods to load the model.In a standard Rails app, this would presumably hit the active record cache and not hit mysql twice, but if the active record cache is invalidated during the request or if
@@session_class#find_by_session_id
was overloaded to do anything else (like perhaps read from an external cache), then the app will end up doing unnecessary work.