-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore note about custom db class in README #178
base: master
Are you sure you want to change the base?
Conversation
Better approach to rails#178
alternatively, #179 |
@ghiculescu I think this is something different. This part of the README references the |
Ooops I misread your changes, sorry! |
It does seem to me like the sessions upgrade task respects custom classes though? https://github.com/rails/activerecord-session_store/blob/master/lib/tasks/database.rake#L24 |
It tries to use the custom class. But it will not work if the custom class does not have a |
Better approach to rails#178
Better approach to rails#178
I like this idea. Have implemented in #179 as part of the other stuff I'm doing, and added you as a co-author. |
Better approach to rails#178
I am not sure if this is correct, but it seems to me that the rake task does not work if users are using a custom class (especially if the table name is different).
My suggestion is to restore the old note.