Retrieve session without any implicit ordering #99
Conversation
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| @@ -55,7 +55,7 @@ def self.find_by_session_id(*args) | |||
| class << self; remove_possible_method :find_by_session_id; end | |||
|
|
|||
| def self.find_by_session_id(session_id) | |||
| where(session_id: session_id).first | |||
| where(session_id: session_id).take | |||
|
@denisj please click rebuild in travis. In this there was temporary error in travis |
|
@dapi the errors still occur |
|
Could you explain why the change? |
|
@rafaelfranca I made that change to avoid implicit ordering on the primary key. |
|
Oh, interesting. Sorry for just noticing this patch now. Would you mind rebasing against |
No description provided.