-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add system tests for action text #26
Conversation
@@ -289,6 +289,7 @@ steps_for("actioncable", "test:integration", service: "default") do |x| | |||
x["retry"] = { "automatic" => { "limit" => 3 } } | |||
end | |||
end | |||
steps_for("actiontext", "test:system", service: "actiontext") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the actiontext
service needs to be defined in docker-compose.yml
. It will need to depend on the chrome
service at minimum.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review, I have updated, but not sure how to verify if this indeed runs successfully 🤔
46688fb
to
8c1107a
Compare
8c1107a
to
d6b9aea
Compare
@rafaelfranca How do we know these tests will run? Or we won't know until the config is merged? |
This error needs to be addressed. https://buildkite.com/rails/rails/builds/92669#0185bcf5-bb3b-4a64-98fb-22afc22c41ba/1032-1056
|
Steps to reproduce locally: git clone https://github.com/rails/rails
cd rails
git clone https://github.com/rails/buildkite-config .buildkite/
RUBY_IMAGE=ruby:3.2 docker-compose -f .buildkite/docker-compose.yml build base
CI=1 docker-compose -f .buildkite/docker-compose.yml run default runner actiontext 'rake test:system' |
I think that error occurs when the path is not found, but i'm not 100% sure... I tried setting the URL but that did not work rails/rails#47030, will take a look at this again later. |
Alghouth I'm not familiar with this area, installing Here are entire test results:
|
I reverted this PR, until we find a fix for it. |
Run the action text integration tests on CI.
alt to rails/rails#46842
Related ticket rails/rails#46804