Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add system tests for action text #26

Merged
merged 1 commit into from
Jan 16, 2023

Conversation

hahmed
Copy link
Contributor

@hahmed hahmed commented Jan 4, 2023

Run the action text integration tests on CI.

alt to rails/rails#46842

Related ticket rails/rails#46804

@@ -289,6 +289,7 @@ steps_for("actioncable", "test:integration", service: "default") do |x|
x["retry"] = { "automatic" => { "limit" => 3 } }
end
end
steps_for("actiontext", "test:system", service: "actiontext")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the actiontext service needs to be defined in docker-compose.yml. It will need to depend on the chrome service at minimum.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review, I have updated, but not sure how to verify if this indeed runs successfully 🤔

@rafaelfranca rafaelfranca merged commit 2c90063 into rails:main Jan 16, 2023
@zzak
Copy link
Member

zzak commented Jan 17, 2023

@rafaelfranca How do we know these tests will run? Or we won't know until the config is merged?

@yahonda
Copy link
Member

yahonda commented Jan 17, 2023

This error needs to be addressed.

https://buildkite.com/rails/rails/builds/92669#0185bcf5-bb3b-4a64-98fb-22afc22c41ba/1032-1056

Error:
ActionText::SystemTestHelperTest#test_filling_in_a_rich-text_area_by_placeholder:
Selenium::WebDriver::Error::UnknownError: unknown error: cannot find Chrome binary

@yahonda
Copy link
Member

yahonda commented Jan 17, 2023

Steps to reproduce locally:

git clone https://github.com/rails/rails
cd rails
git clone https://github.com/rails/buildkite-config .buildkite/
RUBY_IMAGE=ruby:3.2 docker-compose -f .buildkite/docker-compose.yml build base
CI=1 docker-compose -f .buildkite/docker-compose.yml run default runner actiontext 'rake test:system'

@hahmed
Copy link
Contributor Author

hahmed commented Jan 17, 2023

I think that error occurs when the path is not found, but i'm not 100% sure...

I tried setting the URL but that did not work rails/rails#47030, will take a look at this again later.

@yahonda
Copy link
Member

yahonda commented Jan 17, 2023

Alghouth I'm not familiar with this area, installing google-chrome-stable changes the error message to Selenium::WebDriver::Error::UnknownError: unknown error: Chrome failed to start: exited abnormally.. It looks like Chrome is there but fails to startup.

ff9231e

Here are entire test results:
https://gist.github.com/yahonda/38e25661da84019d29d91c5ef78d0f72#file-gistfile1-txt-L912

Error:
ActionText::SystemTestHelperTest#test_filling_in_a_rich-text_area_by_aria-label:
Selenium::WebDriver::Error::UnknownError: unknown error: Chrome failed to start: exited abnormally.
  (unknown error: DevToolsActivePort file doesn't exist)
  (The process started from chrome location /usr/bin/google-chrome is no longer running, so ChromeDriver is assuming that Chrome has crashed.)

@rafaelfranca
Copy link
Member

I reverted this PR, until we find a fix for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants