Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR looks large because this project currently has no testing infrastructure. The vast majority of LOC in this PR are from
Gemfile
andGemfile.lock
files. I have split the PR into two commits to further clarify. The latter commit has the actual testing code, which amounts to ~70 lines of test code + ~70 lines of helper code.This adds test coverage for the
dartsass:install
command. The command is tested against a freshly generated Rails app using the version of Rails that is currently loaded. Thus the installer can be tested with different versions of Rails in CI.Infrastructure has been added to run tests against Rails 6.1, 7.0, 7.1, and
main
branch, all with both Sprockets and Propshaft.