Add an option to add extra load paths #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chipairon
force-pushed
the
configurable-load-paths
branch
from
e1ef099
to
c570e03
Compare
|
Would be lovely to merge this change. We have our assets in some non-standard (and in multiple Engines) folders. |
sedubois
reviewed
Feb 17, 2022
| @@ -36,6 +36,12 @@ Rails.application.config.dartsass.builds = { | |||
|
|
|||
| The hash key is the relative path to a Sass file in `app/assets/stylesheets/` and the hash value will be the name of the file output to `app/assets/builds/`. | |||
|
|
|||
| By default, only files under `app/assets/stylesheets` will be watched. If you'd like to add extra directories, use the `Rails.application.config.dartsass.extra_load_paths` configuration array. | |||
There was a problem hiding this comment.
DHH was suggesting all vendor/assets/stylesheets folders should also be default, is there a way to do that?
There was a problem hiding this comment.
Yes, it seems a better approach #11
dnwilson
reviewed
Feb 17, 2022
| @@ -4,5 +4,6 @@ module Dartsass | |||
| class Engine < ::Rails::Engine | |||
| config.dartsass = ActiveSupport::OrderedOptions.new | |||
| config.dartsass.builds = { "application.scss" => "application.css" } | |||
| config.dartsass.extra_load_paths = [] | |||
There was a problem hiding this comment.
You could also load all stylesheets by default
config.dartsass.paths = []
def default_paths
Rails.application.config.assets[:paths].select do |path|
path.to_s.match?(/stylesheets/)
end
end
def load_paths
use_paths = config.dartsass.paths || default_paths
[CSS_LOAD_PATH].concat(use_paths).map { |path| "--load-path #{path}" }.join(" ") }
end
There was a problem hiding this comment.
Yeah I think is a better approach and doesn't require extra configuration #11
|
Closed in favour of #11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows to add extra load paths to the sass executable.
It is helpful when the an app has cutomized the entry points as well as when the entry points references other files that reside outside of the default
CSS_LOAD_PATH.That way, when files are changed under those extra directories,
dartsass:watchwill trigger a rebuild.