Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add direct V8 support (via d3) #25

Merged
merged 1 commit into from
Sep 9, 2015
Merged

Add direct V8 support (via d3) #25

merged 1 commit into from
Sep 9, 2015

Conversation

ojab
Copy link
Contributor

@ojab ojab commented Sep 8, 2015

rake test passes here with v8-4.5.103.29 on Mac OS X.
It also should be added to travis, but I'm not really sure how it should be done (plain sudo apt-get install v8 in before_install or somewhat else).

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rafaelfranca
Copy link
Member

@ojab thanks! Could you try adding this to the travis config?

addons:
  apt:
    packages:
    - v8

@ojab
Copy link
Contributor Author

ojab commented Sep 9, 2015

Unfortunately there is no pkgs with d3 in ubuntu (only libv8 without console runner), so tests fail.
Added v8 installation/testing to osx instead, it works.

rafaelfranca added a commit that referenced this pull request Sep 9, 2015
Add direct V8 support (via `d3`)
@rafaelfranca rafaelfranca merged commit 4fe3fd6 into rails:master Sep 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants