Don't attach UJS form submission handlers to Turbo forms #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows for easier migration of apps written for UJS, such that new work can be done with Turbo forms that are marked with data-turbo=true.
|
a remote form in our project fails now with 1.2.3. we thought of problems with assets and precompiling, as we updated server and setups. |
|
Please do open a PR when you find a solution ✌️ |
carlosantoniodasilva
added a commit
to rails/jquery-rails
that referenced
this pull request
Nov 10, 2022
It contains improved compatibility with turbo. rails/jquery-ujs#521 Closes #284
smartech7
pushed a commit
to smartech7/jquery-rails
that referenced
this pull request
Aug 4, 2023
It contains improved compatibility with turbo. rails/jquery-ujs#521 Closes #284
|
I wonder if it's something to do with jquery not declared as dependency in 1.2.3... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you're migrating an application written for Rails UJS to the new Turbo framework in Hotwire, you might well want to have Turbo and UJS coexisting during the migration (or forever!). To do this, you need a way to distinguish how handles form submissions. With these updated selectors, Rails UJS will leave forms marked with data-turbo=true alone, leaving them to be processed by Turbo.
(Mirror PR of rails/rails#42476).