Adds support for relative url root #138
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #103
This replaces PR #130 to add support for relative_url_root
@brenogazzola hopefully this is easier to review.
You had commented that the below may need to account for the relative_url_root
mount app.assets.server => app.assets.config.prefix
We use rack config (config.ru) to run rails in the subdirectory as below, so we don't need the above changed
We are currently using this change in our development pipeline, and it has been deployed to production. For production the static assets are served up by a separate server under the relative url.