Improve source mapping compiler log message #163
Conversation
| @logical_path = logical_path | ||
| input.gsub(SOURCE_MAPPING_PATTERN) { source_mapping_url(asset_path($2), $1, $3) } |
There was a problem hiding this comment.
I'm not much of a fan of setting instance variables in the middle of methods to avoid passing them forward. Specially because the other two methods that use it still need other variables passed as parameters. Better to repeat logical_path here
There was a problem hiding this comment.
Thanks, I made the changes you asked. But I'd like to clarify why I decided on the previous path: logical_path is used in all methods of the class, so it's usually recommended to store it in an instance variable so that you don't need to pass it as parameters everywhere. And more parameters usually also make code harder to read.
esasse
force-pushed
the
sourcemap-logmessage
branch
from
936cbf9
to
0d06a66
Compare
|
@brenogazzola any other changes you want me to do so that this PR can be merged? |
|
Thanks, sorry for the delay! |
Improves previous PR #145.
Now the
logical_pathis properly logged, making it easier to find the problem.