Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 404 for loading source maps with digests in url #194

Merged
merged 1 commit into from
Jun 2, 2024

Conversation

theodorton
Copy link
Collaborator

@theodorton theodorton commented May 30, 2024

See reported issue #193.

Bisecting on v0.8 shows regression introduced in #171.

@theodorton theodorton merged commit af557fb into main Jun 2, 2024
6 checks passed
@theodorton theodorton deleted the fix-source-map-404 branch June 2, 2024 10:50
@searls
Copy link

searls commented Jun 18, 2024

Just got bit by this after running bundle update -- it'd be awesome if you could cut a patch release, because this 404 was a bit confusing to figure out before visiting the propshaft's commit history

@dixpac
Copy link
Contributor

dixpac commented Aug 10, 2024

@dhh @brenogazzola can we release the latest changes? I've just spend 2 hours trying to figure out why source-maps are not working on 0.9.0 🙏

@dhh
Copy link
Member

dhh commented Aug 12, 2024

Will cut a release.

@dhh
Copy link
Member

dhh commented Aug 12, 2024

0.9.1 has been released: https://github.com/rails/propshaft/releases/tag/v0.9.1

@searls
Copy link

searls commented Aug 13, 2024

Thanks @dhh!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants