Skip to content

fix: add JC canonical name #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −0
Open

fix: add JC canonical name #324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f4c835
fix: add JC canonical name
dijonkitchen Feb 6, 2025
13a55f9
fix: add missing comma
dijonkitchen Feb 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/models/names_manager/canonical_names.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,6 +554,7 @@ def self.map(canonical_name, *also_as)
map 'Jason Stirk', "jstirk\100oobleyboo.com"
map 'Javier Ramírez', 'jramirez'
map 'Jay Levitt', "jay\100jay.fm"
map 'JC (Jonathan Chen)', 'Jonathan Chen'
map 'Jean Baptiste Barth', 'jbbarth'
map 'Jean Boussier', 'Jean byroot Boussier'
map 'Jean Helou', "jean.helou\100gmail.com", 'jean.helou'
Expand Down
4 changes: 4 additions & 0 deletions test/credits/canonical_names_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2263,6 +2263,10 @@ class CanonicalNamesTest < ActiveSupport::TestCase
assert_contributor_names '4d9ca4d', 'Jon Bright'
end

test "Jonathan Chen" do
assert_contributor_names '58b4448', 'JC (Jonathan Chen)'
end

test "jonathan\100bluewire.net.nz" do
assert_contributor_names '1aff68d', 'Jonathan Viney'
end
Expand Down