Adding rails-controller-testing** gem does not fix NoMethodError message

[jasnow]

Adding rails-controller-testing gem to my Rails 5 fork of codeforatlanta's show-me-the-food5 (https://github.com/jasnow/show-me-the-food5) repo's Gemfile does not fix the following message:

• NoMethodError:assigns has been extracted to a gem. To continue using it, add gem 'rails-controller-testing' to your Gemfile.

Appears to not be the only one: http://stackoverflow.com/questions/30605868/rails-controller-testing-gem

---

If you run "rake" before upgrading to the most recent version of Rails 5, no tests break.

After adding the gem rails-controller-testing, running "bundle update", and then running "rake," you get:

Failures:

  1) LocationsController#index assigns @locations
     Failure/Error: subject{ assigns(:locations) }
     NoMethodError:
       assigns has been extracted to a gem. To continue using it,
               add `gem 'rails-controller-testing'` to your Gemfile.
     # /home/jasnow/.rvm/gems/ruby-2.2.2/bundler/gems/rails-7220ffcffd00/
       actionpack/lib/action_dispatch/testing/test_process.rb:8:in `assigns'
     # ./spec/controllers/locations_controller_spec.rb:5:in `block
       (3 levels) in <top (required)>'
     # ./spec/controllers/locations_controller_spec.rb:9:in `block
       (3 levels) in <top (required)>'

Finished in 0.29375 seconds (files took 3.41 seconds to load)
1 example, 1 failure

[tgxworld]

@JasonW i'll have to fix this. The gem was built under the assumption that the methods would have only been deprecated and not raise a warning. Sorry about that 😘

[jasnow]

Question: Will this fix be in this gem or in Rails?

[tgxworld]

@jasnow I couldn't replicate the issue with the demo app. Could you check if you have the latest version of the Gem installed? Thanks 😄

[jasnow]

You must run "bundle update" and add the new gem and then run "rake" and see that adding the new gem did not get rid of the message.

[tgxworld]

Ah ok. This only happens when using RSpec, let me have another look at it.

[bunneyster]

Hi, I'm using the default Rails testing framework, and I am still seeing the same issue as @jasnow. If you take a look at this repo, you can run rake test on the master branch (rails-4.2.0) to see all the tests pass, and on the rails5 branch (edge rails) to see tests error out. Thank you for your help!

[tgxworld]

@sPark008 Ok I'm seeing the same failures with your app. Could you try out https://github.com/tgxworld/test-app and see if the tests passes for you?

[tgxworld]

@sPark008 Ah I see what is happening for your app. Your app is using a custom test_helper. If you require 'rails-controller-testing', you'll stop getting those errors.

[redbassett]

+1, upgraded an existing app to edge rails and tests (Minitest) give the message despite having the gem installed at version 0.0.3.

[tgxworld]

@redbassett RSpec or Minitest?

[redbassett]

Default testing. (So Minitest)

[tgxworld]

@redbassett could you provide more information? So far, RSpec is known to be broken because RSpec implements assign. I pushed a test app above to demonstrate that it works with edge Rails on Minitest.

[redbassett]

Apologies!

I have the following line of code:
assert_equal assigns(:user).remember_token, cookies['remember_token']

It was in place in a test before I upgraded, and passed fine. After the upgrade, I have started getting the following error:

NoMethodError: assigns has been extracted to a gem. To continue using it,
       add `gem 'rails-controller-testing'` to your Gemfile.

This is despite having the gem installed at version 0.0.3. I have not changed the configuration of testing from the default, and this is inside a test block in an integration test.

[tgxworld]

@redbassett Could you replicate this in a simple app?