selector_assertions/html_selector: No trailing . on content_mismatch
#102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- I was refreshing my Rails knowledge by following a Rails tutorial (but with the latest gem versions) and I found that when I used `assert_select` and it failed, the message was printed like: ``` 1) Failure: StaticPagesControllerTest#test_should_get_about [/Users/issyl0/repos/issyl0/rails-tutorial/sample_app/test/controllers/static_pages_controller_test.rb:24]: <About | Ruby on Rails Tutorial Sample App> expected but was <About| Ruby on Rails Tutorial Sample App>.. Expected 0 to be >= 1. ``` - That is, the "expected but was" sentence ends with two periods. There's an example of this output in the [release notes for Rails 4.2 about `assert_select` behaviour changes](https://edgeguides.rubyonrails.org/4_2_release_notes.html#assert-select), so it's pretty old. But even so, the two periods to end the sentence looked weird to me. - I did look at the MiniTest code to see if I could upstream this further (`if message.end_with?(".")` then don't add another period, or something), but I couldn't find the place to do it and I was also surprised that someone else hadn't noticed this before, so I thought I'd leave that alone as there are probably reasons that are way beyond my levels of understanding of the interactions between MiniTest's core functionality vs. this gem!
sikachu
approved these changes
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert_selectand it failed, the message was printed like:assert_selectbehaviour changes, so it's pretty old. But even so, the two periods to end the sentence looked weird to me.if message.end_with?(".")then don't add another period, or something), but I couldn't find the place to do it and I was also surprised that someone else hadn't noticed this before, so I thought I'd leave that alone as there are probably reasons that are way beyond my levels of understanding of the interactions between MiniTest's core functionality vs. this gem!