Expand Substitution Matching Types support #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dig it! Is there someplace we need to update the documentation too? This was some of the first Rails related code I wrote way back in 2013 and now I shudder that I didn't just fix |
|
@kaspth great question! This repository seems light on documentation. I can't find any mention of substitutions in assertions in the README, and the link back to Rails is for the 4.2 release. Is there somewhere in Rails that mentions substitutions? |
|
It's documented here, it seems |
Add substitution support for `Symbol` and `Numeric`. It can be convenient to pass in the value of an `ActiveRecord::Base#id`, or a `Symbol` declared elsewhere in the test.
seanpdoyle
force-pushed
the
substitution-types
branch
from
0f01be0 to
288aa9e
Compare
seanpdoyle
commented
Dec 3, 2020
| # with substitution values (Array). | ||
| # Substitution uses a custom pseudo class match. Pass in whatever attribute you want to match (enclosed in quotes) and a ? for the substitution. | ||
| # assert_select returns nil if called with an invalid css selector. | ||
| # | ||
| # assert_select "div:match('id', ?)", "id_string" | ||
| # assert_select "div:match('id', ?)", :id_string | ||
| # assert_select "div:match('id', ?)", 1 |
There was a problem hiding this comment.
@kaspth is this what you had in mind?
|
Yes, that's it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add substitution support for
SymbolandNumeric. It can beconvenient to pass in the value of an
ActiveRecord::Base#id, or aSymboldeclared elsewhere in the test.