Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore inferred association class with the same modularized name #51948

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

justinko
Copy link
Contributor

@justinko justinko commented May 30, 2024

Fixes #51938

Motivation / Background

#51721 was a nice change, but it removed some existing behavior.

Detail

This change restores the ability for the inferred association class to be the same modularized name.

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Unrelated changes should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

Copy link
Contributor

@joshuay03 joshuay03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies for the breaking change, this looks good to me 👍🏽 Thanks for getting a PR up!

@byroot byroot merged commit 78ce299 into rails:main Jul 8, 2024
2 of 3 checks passed
@tagliala
Copy link
Contributor

tagliala commented Aug 15, 2024

Hello, this commit is fixing an issue on Rails 7.2 that I'm not confident to present at the moment

The issue was introduced in: #51721 329260cc0f

It is present on 7.2.0 and 7-2-stable

Is this PR going to be backported to 7-2-stable branch?

@rafaelfranca
Copy link
Member

Backported

rafaelfranca pushed a commit that referenced this pull request Aug 15, 2024
Restore inferred association class with the same modularized name
@tagliala
Copy link
Contributor

Thanks, just as confirmation specs now passa against 7-2-stable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Association klass with same demodularized name raises error when demodularized class is undefined
5 participants