Use updated Sidekiq wrapper class name in test

[zzak]

This is due to sidekiq/sidekiq@4d80a26 changing the name used when queueing jobs.

/cc @yahonda @seuros

[seuros]

This condition will be always true, since we always test on latest.

[zzak]

🤔 It was late, I was thinking this would be easier to backport, but in any case we don't lock the version of sidekiq afaik so we should just update the name, I guess.

[yahonda]

One of the reasons I hesitated to merge this pull request is the note in the Sidekiq changelog stating that “the old name will still work in 8.x.” https://github.com/sidekiq/sidekiq/blob/main/Changes.md?plain=1#L37-L38

Given that, I was expecting the old name ActiveJob::QueueAdapters::SidekiqAdapter::JobWrapper to continue working in Sidekiq 8.0.3 and later versions of 8.x.

I also noticed that similar tests already exist on the Sidekiq side—for example. https://github.com/sidekiq/sidekiq/blob/aee9da68706536fcacbaad069794644f027c3278/test/active_job_adapter_test.rb#L47-L68

So I’m wondering whether we need to keep this integration test in Rails, or if it might be redundant.

[zzak]

@yahonda I'm on the fence about removing the test, because for historical purposes (i.e. stable branches) it's value is that:

• Given an ActiveJob object is enqueued, the class of that job is our JobWrapper

But the actual name is an implementation detail, and not even public API:

rails/activejob/lib/active_job/queue_adapters/async_adapter.rb

Line 63 in 4b7fb1d

class JobWrapper # :nodoc:

So the value of the test is purely internal, iiuc.

Meaning we get to choose if we want to maintain it or not.

If we do, I can see #55148 as an acceptable alternative to this.