[close #381] Avoid Sprockets deprecations #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
schneems
force-pushed
the
schneems/fix-deprecations
branch
2 times, most recently
from
15e6092 to
5f306d3
Compare
- Use both `register_engine` and `register_transformer` in railtie.rb. - In the test postprocessor use an object that responds to `call` and `new.render`.
Add required manifest files so we don't get exceptions. In sprockets 4 when you render a `.scss` file it will give you the raw file instead of the generated CSS. To fix tests we must generate css instead of scss.
schneems
force-pushed
the
schneems/fix-deprecations
branch
from
c740ae4 to
2a511cf
Compare
Two arguments get passed in, so we need to arguments in the interface.
| env.register_engine '.scss', Sass::Rails::ScssTemplate, silence_deprecation: true | ||
| args = ['.sass', Sass::Rails::SassTemplate] | ||
| args << { silence_deprecation: true } if env.method(:register_engine).arity > 2 | ||
| env.register_engine *args |
There was a problem hiding this comment.
I guess we'd better put brackets here or we'll get warning: *' interpreted as argument prefix
damianlegawiec
added a commit
to spree/spree_starter
that referenced
this pull request
Aug 16, 2016
carlosdeveloper11
added a commit
to carlosdeveloper11/rails_react_boilerplate
that referenced
this pull request
May 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.