Skip to content

Commit

Permalink
Lets just match the SQ here on the version requirement
Browse files Browse the repository at this point in the history
  • Loading branch information
@dhh
dhh committed Sep 5, 2024
1 parent 0ccb4c6 commit 8919965
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/generators/solid_cache/install/templates/db/cache_schema.rb
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true

ActiveRecord::Schema[7.2].define(version: 1) do
ActiveRecord::Schema[7.1].define(version: 1) do
create_table "solid_cache_entries", force: :cascade do |t|
t.binary "key", limit: 1024, null: false
t.binary "value", limit: 536870912, null: false
Expand Down

2 comments on commit 8919965

@npezza93
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think keeping 7.2 here makes sense due to the constraint in the gemspec and #192

@dhh
Copy link
Member Author

@dhh dhh commented on 8919965 Sep 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes. Doesn't really matter since the minimum is enforced elsewhere but might as well make it consistent 👍

Please sign in to comment.