Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix unprepared statements #185

Merged
merged 14 commits into from
Jul 23, 2024
Merged

fix unprepared statements #185

merged 14 commits into from
Jul 23, 2024

Conversation

ollym
Copy link
Contributor

@ollym ollym commented Jul 3, 2024 •
edited
Loading

Fixes #184

@ollym ollym marked this pull request as draft July 3, 2024 14:46
@ollym ollym marked this pull request as ready for review July 3, 2024 16:51
@ollym
Copy link
Contributor Author

ollym commented Jul 3, 2024

Finally got this working @djmb sorry for the messy commits took a bit of back and forth but this is now passing all tests for prepared_statements: false and also extends the testing framework to ensure we run all tests against this as a scenario. This should be ready to go and would appreciate a review, thanks!

djmb
djmb reviewed Jul 22, 2024
View reviewed changes
Copy link
Collaborator

@djmb djmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ollym,

Thanks for the PR and sorry for the delay in reviewing it!

Looks good to me, I just had one small suggestion.

app/models/solid_cache/entry.rb Outdated Show resolved Hide resolved
@ollym
Copy link
Contributor Author

ollym commented Jul 22, 2024

Fixed

@djmb djmb merged commit c96b69c into rails:main Jul 23, 2024
37 checks passed
@ollym ollym deleted the fix-unprepared-statements branch July 23, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djmb djmb djmb left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug with prepared_statements: false and read_multi
2 participants
@ollym @djmb