Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds fallback to app_name_from_production_database_name #209

Closed
wants to merge 2 commits into from

Conversation

emars
Copy link

@emars emars commented Sep 5, 2024

app_name_from_production_database_name can sometimes return nil if your config does not match the expected format.

This pull request adds a default to this method so the generator does not fail when calling app_name.upcase.

Co-authored-by: Tejas <tejas-shetty@outlook.com>
@dhh
Copy link
Member

dhh commented Sep 9, 2024

I'd actually rather follow the lead from solid_queue and yank this munging all together. Rails 8 will do this configuration directly in config/database.yml out of the box, and I think it's too likely that we won't match things right otherwise. So should update the README to just be explicit about what you need to add to config/database.yml.

@dhh dhh closed this Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants