Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to avoid using the ActiveRecord query cache entirely with SolidCache:
Rails.cache.write
to do that.Ideally we'd just be able to do something like:
Absent that we need to do a bunch of gymnastics to get the behaviour we want.
Selects - This is easy enough, we just wrap the query in an
uncached
blockUpserts - Here we need to avoid calling
connection.exec_insert_all
as that will dirty the query cache. Instead we have to construct the SQL manually and execute it withconnection.exec_query
.Deletes - Similarly we need to avoid calling
connection.delete
here. Again we construct the SQL manually and execute it withconnection.exec_delete
.