Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For deleted recurring_tasks #310

Closed
tmimura39 opened this issue Aug 29, 2024 · 2 comments
Closed

For deleted recurring_tasks #310

tmimura39 opened this issue Aug 29, 2024 · 2 comments

Comments

@tmimura39
Copy link
Contributor

Hi, Let me ask you a question about #272.

This support is very convenient as it allows recurring_tasks to be checked in MissionControl. thanks 👍

However, there seems to be a problem with “recurring_tasks deleted from the YAML configuration file” that continue to remain on the MissionControl dashboard.

This is because we only process create or update for SolidQueue::RecurringTask.

def persist_tasks
SolidQueue::RecurringTask.create_or_update_all configured_tasks
end

We do not think this is a major issue since the task does not continue to run, just remains on the MissionControl dashboard.
However, as the recurring_task setting is repeatedly added and removed, the MissionControl dashboard becomes polluted.

Is this the intended behavior?

@rosa
Copy link
Member

rosa commented Aug 29, 2024

Yes, it's intended, for now. The reason is that the current setup allows you to have multiple dispatchers, running different recurring tasks so a single dispatcher can't delete all tasks that aren't in its configuration because they might belong to a different dispatcher with a different configuration.

I plan to improve this, though, and clean up these old tasks. I have other improvements that I need to implement for recurring tasks, so I'll do all those together.

@tmimura39
Copy link
Contributor Author

Thanks for the reply!

Yes, I agree. I didn't think it would be easy.

I'm looking forward to seeing more improvements in the future!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants