Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recurring schedule is not deleting removed tasks #359

Closed
majkelcc opened this issue Sep 24, 2024 · 7 comments
Closed

Recurring schedule is not deleting removed tasks #359

majkelcc opened this issue Sep 24, 2024 · 7 comments

Comments

@majkelcc
Copy link

Tasks deleted from config/schedule.yml are not being removed from the schedule.

@rosa
Copy link
Member

rosa commented Sep 24, 2024

Hey @majkelcc, is this #310, or are actually deleted tasks still being run?

@majkelcc
Copy link
Author

Hi @rosa, that's it! All makes sense when dealing with multiple dispatchers. After dealing with the other issues around recurring configuration I forgot to scan previous issues for this. Maybe it's worth it to add a note in README on how this works currently?

@rosa
Copy link
Member

rosa commented Sep 24, 2024

I'm going to change it so that a single scheduler is allowed to simplify things, so yes, I'll add a note in the README about it and will also delete previous tasks.

@jwald1
Copy link

jwald1 commented Dec 26, 2024

Is removing a job from recrring.yml supposed to delete the job? I tried it, but it didn’t seem to work. Just for context, I’m using the latest versions of mission_control and sold_queue.

@rosa
Copy link
Member

rosa commented Dec 26, 2024

@jwald1, what do you mean by "delete the job"? That it disappears from the recurring tab in Mission Control? That if there's an execution in progress, it stops? If the first, yes, if the second, no.

@jwald1
Copy link

jwald1 commented Dec 26, 2024

Thanks, @rosa. I mean, "That it disappears from the recurring tab in Mission Control."

@rosa
Copy link
Member

rosa commented Dec 26, 2024

Aha, then it should be removed once you restart the scheduler so it picks the new configuration in recurring.yml. Normally that would happen as part of the deployment that you'd need to update the file itself. It's that not happening for you? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants