Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rely on ActiveSupport::Notifications and ActiveSupport::LogSubscriber for logging and instrumentation #208

Merged
merged 12 commits into from
May 8, 2024

Commits on Apr 30, 2024

  1. Implement basic structure to use Active Support notifications and log…

    … subscribers
    
    And instrument a bunch of actions.
    rosa committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    9e894a5 View commit details
    Browse the repository at this point in the history
  2. Write tests for instrumentation and fix a few bugs found along the way

    Fix bug found for async execution mode when worker didn't correctly finish
    shutting down.
    
    Also, always instrument retry_all and release_many_blocked even if none is
    retried/released, so we have that information as well, with the number of jobs
    that actually were acted on.
    rosa committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    e855a33 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4152fab View commit details
    Browse the repository at this point in the history
  4. Instrument discard and discard_all (in batches and from jobs)

    And fix issue when discarding in batches, where the discarded count
    was always being zero when the foreign key with cascade deletion is
    present from jobs to ready executions. Discarding all jobs would delete
    all ready executions in cascade, and then deleting them afterwards, for
    the case where there aren't any foreign keys, would return 0 jobs
    discarded.
    rosa committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    740c20f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    af48e6e View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    94ae87a View commit details
    Browse the repository at this point in the history
  7. Fix instrumentation of error when deregistering process

    This was sending two events per error instead of one.
    rosa committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    3c3ac33 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    7fcae9a View commit details
    Browse the repository at this point in the history
  9. Move some more manual logging lines to Active Support notifications

    And set log subscriber's logger to be Solid Queue's logger.
    
    Also: refactor a bit how (OS) process attributes are exposed so they can
    be logged more easily.
    rosa committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    7095a8b View commit details
    Browse the repository at this point in the history
  10. Replace the last direct calls to Solid Queue's logger

    With Active Support notifications.
    rosa committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    84dd066 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    c0b52a5 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. Instrument process shutdown and add some more info to replaced fork e…

    …vent
    
    So we at least can tell when it received a SIGKILL or when it exited normally.
    rosa committed May 1, 2024
    Configuration menu
    Copy the full SHA
    b9db22d View commit details
    Browse the repository at this point in the history