-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rely on ActiveSupport::Notifications
and ActiveSupport::LogSubscriber
for logging and instrumentation
#208
Commits on Apr 30, 2024
-
Implement basic structure to use Active Support notifications and log…
… subscribers And instrument a bunch of actions.
Configuration menu - View commit details
-
Copy full SHA for 9e894a5 - Browse repository at this point
Copy the full SHA 9e894a5View commit details -
Write tests for instrumentation and fix a few bugs found along the way
Fix bug found for async execution mode when worker didn't correctly finish shutting down. Also, always instrument retry_all and release_many_blocked even if none is retried/released, so we have that information as well, with the number of jobs that actually were acted on.
Configuration menu - View commit details
-
Copy full SHA for e855a33 - Browse repository at this point
Copy the full SHA e855a33View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4152fab - Browse repository at this point
Copy the full SHA 4152fabView commit details -
Instrument discard and discard_all (in batches and from jobs)
And fix issue when discarding in batches, where the discarded count was always being zero when the foreign key with cascade deletion is present from jobs to ready executions. Discarding all jobs would delete all ready executions in cascade, and then deleting them afterwards, for the case where there aren't any foreign keys, would return 0 jobs discarded.
Configuration menu - View commit details
-
Copy full SHA for 740c20f - Browse repository at this point
Copy the full SHA 740c20fView commit details -
Configuration menu - View commit details
-
Copy full SHA for af48e6e - Browse repository at this point
Copy the full SHA af48e6eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 94ae87a - Browse repository at this point
Copy the full SHA 94ae87aView commit details -
Fix instrumentation of error when deregistering process
This was sending two events per error instead of one.
Configuration menu - View commit details
-
Copy full SHA for 3c3ac33 - Browse repository at this point
Copy the full SHA 3c3ac33View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7fcae9a - Browse repository at this point
Copy the full SHA 7fcae9aView commit details -
Move some more manual logging lines to Active Support notifications
And set log subscriber's logger to be Solid Queue's logger. Also: refactor a bit how (OS) process attributes are exposed so they can be logged more easily.
Configuration menu - View commit details
-
Copy full SHA for 7095a8b - Browse repository at this point
Copy the full SHA 7095a8bView commit details -
Replace the last direct calls to Solid Queue's logger
With Active Support notifications.
Configuration menu - View commit details
-
Copy full SHA for 84dd066 - Browse repository at this point
Copy the full SHA 84dd066View commit details -
Configuration menu - View commit details
-
Copy full SHA for c0b52a5 - Browse repository at this point
Copy the full SHA c0b52a5View commit details
Commits on May 1, 2024
-
Instrument process shutdown and add some more info to replaced fork e…
…vent So we at least can tell when it received a SIGKILL or when it exited normally.
Configuration menu - View commit details
-
Copy full SHA for b9db22d - Browse repository at this point
Copy the full SHA b9db22dView commit details